Refactor code structure for improved readability and maintainability

src/app/domains/partner/modules/consumers/components/businessActivities/create-wrapper/create-wrapper.component.html

@@ -19,7 +19,6 @@
       @case (1) {
         <partner-consumer-businessActivities-form-content
           [consumerId]="consumerId"
-          [visible]="visible"
           (onSubmit)="onBusinessActivitySubmit($event)"
           (onClose)="close()"
         />

src/app/domains/partner/modules/consumers/components/businessActivities/form-dialog.component.html

@@ -11,7 +11,6 @@
     [businessActivityId]="businessActivityId"
     [initialValues]="initialValues"
     [editMode]="editMode"
-    [visible]="visible"
     (onSubmit)="onFormSubmit($event)"
     (onClose)="close()"
   />

src/app/domains/partner/modules/consumers/components/businessActivities/form.component.ts

@@ -38,7 +38,6 @@ export class ConsumerBusinessActivitiesFormComponent extends AbstractForm<
 
   @Input({ required: true }) consumerId!: string;
   @Input() businessActivityId!: string;
-  @Input({ required: true }) visible!: boolean;
 
   initForm = () => {
     const form = this.fb.group({

src/app/domains/partner/modules/consumers/components/poses/form.component.ts

@@ -1,5 +1,5 @@
 // import { CatalogRolesComponent } from '@/shared/catalog/roles';
-import { MustMatch } from '@/core/validators';
+import { MustMatch, usernameValidator } from '@/core/validators';
 import { AbstractForm } from '@/shared/abstractClasses';
 import {
   DeviceIdComponent,
@@ -49,9 +49,9 @@ export class ConsumerPosFormContentComponent extends AbstractForm<IPosRequest, I
       serial_number: fieldControl.serial_number(this.initialValues?.serial_number || ''),
       device_id: fieldControl.device_id(this.initialValues?.device?.id || ''),
       provider_id: fieldControl.provider_id(this.initialValues?.provider?.id || ''),
-      username: [''],
-      password: [''],
-      confirmPassword: [''],
+      username: fieldControl.username(),
+      password: fieldControl.password(),
+      confirmPassword: fieldControl.confirmPassword(),
     });
 
     form.controls.pos_type.valueChanges.subscribe((value) => {
@@ -89,30 +89,8 @@ export class ConsumerPosFormContentComponent extends AbstractForm<IPosRequest, I
       form.removeControl('confirmPassword');
       form.removeValidators([MustMatch('password', 'confirmPassword')]);
     } else {
-      // @ts-ignore
-      form.addControl(
-        'username',
-        this.fb.control<string>('', {
-          nonNullable: true,
-          validators: fieldControl.username('')[1],
-        }),
-      );
-      // @ts-ignore
-      form.addControl(
-        'password',
-        this.fb.control<string>('', {
-          nonNullable: true,
-          validators: [Validators.required],
-        }),
-      );
-      // @ts-ignore
-      form.addControl(
-        'confirmPassword',
-        this.fb.control<string>('', {
-          nonNullable: true,
-          validators: [Validators.required],
-        }),
-      );
+      form.controls.username.setValidators([Validators.required, usernameValidator()]);
+      form.controls.username.updateValueAndValidity({ emitEvent: false });
       form.addValidators([MustMatch('password', 'confirmPassword')]);
     }